From: Christian Couder <chriscool@tuxfamily.org>
Date: Thu, 09 Apr 2009 03:11:08 GMT
Subject: Re: [PATCH 2/3] rev-list: remove last static vars used in "show_commit"
Message-ID: <200904090511.08242.chriscool@tuxfamily.org>
In-Reply-To: <49DC54DC.3060408@gnu.org>

Le mercredi 8 avril 2009, Paolo Bonzini a écrit :
> >  	struct rev_info revs;
> > +	struct rev_list_info info;
> >  	int reaches = 0, all = 0;
> >
> > +	memset(&info, 0, sizeof(info));
> > +	info.revs = &revs;
>
> Would it make sense to embed the struct rev_info entirely in the new
> struct, without going through a pointer?

Perhaps, I will have a look.

The downside is that the struct rev_info may be initialized twice if we 
still use "memset(&info, 0, sizeof(info))" as it is also initialized 
in "init_revisions".

Thanks,
Christian.