From: Jeff King <peff@peff.net>
Date: Wed, 08 Apr 2009 06:27:17 GMT
Subject: Re: [PATCH 2/5] for-each-ref: refactor refname handling
Message-ID: <20090408062717.GA26929@coredump.intra.peff.net>
In-Reply-To: <7vprfnr7es.fsf@gitster.siamese.dyndns.org>

On Tue, Apr 07, 2009 at 11:22:51PM -0700, Junio C Hamano wrote:

> > The diff is scary, but it is mostly reindentation.
> ... and an introduction of a bug ;-)

Oops. 

> > +				die("unknown %.*s format %s",
> > +					formatp - name, name, formatp);
> 				die("unknown %.*s format %s",
>                                     (int)(formatp - name), name, formatp);

Hey, it's all 32 bits, right? ;)

Thanks for spotting it.

-Peff