From: Jeff King <peff@peff.net>
Date: Sun, 05 Apr 2009 19:59:09 GMT
Subject: Re: [PATCH 1/4] sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1
Message-ID: <20090405195908.GB4716@coredump.intra.peff.net>
In-Reply-To: <fabb9a1e0904051206l11a629cald95a794815c2d76f@mail.gmail.com>

On Sun, Apr 05, 2009 at 09:06:56PM +0200, Sverre Rabbelier wrote:

> > It is an assert, and I think Peff's die("BUG: ...") would be a good idea.
> 
> As long as the <something that makes sense to the user> does indeed
> make sense, right :).

I think:

  die("BUG: assertion failed in binary search")

would be sufficient to tell the user what is going on, and let them
inform the list what happened.

However, if this "oops" has been there for 2 years and nobody has seen
it, it's entirely possible that somebody actually got the binary search
code right in the first place. ;)

-Peff