From: Finn Arne Gangstad Date: Fri, 03 Apr 2009 09:00:36 GMT Subject: [PATCHv2 0/2] git remote update: New option --prune (-p) Message-ID: <20090403090036.GA23955@pvv.org> In-Reply-To: <7vljqieq1r.fsf@gitster.siamese.dyndns.org> On Thu, Apr 02, 2009 at 01:52:48PM -0700, Junio C Hamano wrote: > Finn Arne Gangstad writes: > > > On Thu, Apr 02, 2009 at 11:06:56AM -0700, Junio C Hamano wrote: > >> [...] > >> > >> I gave the patch an only cursory look, so I wouldn't comment on the > >> implementation; two things I would look at in the code would be if it > >> makes two connections to the remote to learn the same information (which > >> would be bad) > > > > How bad? > > I'd say only "could be improved later" bad. Ok. I split the patch into two to make it easier to review. 1/2 just splits out prune_remote() as a separate function, and does not change any behavior. 2/2 adds the new option to remote update. Finn Arne Gangstad (2): builtin-remote.c: Split out prune_remote as a separate function. git remote update: New option --prune Documentation/git-remote.txt | 4 ++- builtin-remote.c | 76 ++++++++++++++++++++++++++---------------- 2 files changed, 50 insertions(+), 30 deletions(-) - Finn Arne