From: Karl Hasselström <kha@treskal.com>
Date: Wed, 01 Apr 2009 12:05:15 GMT
Subject: Re: [StGit PATCH] Convert "pop" to the lib infrastructure
Message-ID: <20090401120515.GA30918@diana.vm.bytemark.co.uk>
In-Reply-To: <20090331113027.2524.60993.stgit@pc1117.cambridge.arm.com>

On 2009-03-31 12:30:27 +0100, Catalin Marinas wrote:

> @@ -47,7 +47,7 @@ test_expect_success 'Try to reset with --hard' '
>      stg reset --hard master.stgit^~1 &&
>      stg status a > actual.txt &&
>      test_cmp expected.txt actual.txt &&
> -    test "$(echo $(stg series))" = "> p1 - p3 - p2"
> +    test "$(echo $(stg series))" = "> p1 - p2 - p3"
>  '

Hmm, why this change in behavior? Something that should be noted in
the commit message?

> @@ -47,7 +47,7 @@ test_expect_success 'Try to undo with --hard' '
>      stg undo --hard &&
>      stg status a > actual.txt &&
>      test_cmp expected.txt actual.txt &&
> -    test "$(echo $(stg series))" = "> p1 - p3 - p2"
> +    test "$(echo $(stg series))" = "> p1 - p2 - p3"
>  '

And I guess this is the same.

Otherwise, this looks good.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle