From: Jeff King Date: Tue, 31 Mar 2009 22:25:42 GMT Subject: Re: bsd group semantics Message-ID: <20090331222540.GA25820@coredump.intra.peff.net> In-Reply-To: <7vr60d4btl.fsf@gitster.siamese.dyndns.org> On Tue, Mar 31, 2009 at 02:33:26PM -0700, Junio C Hamano wrote: > > - # All directories must have 2770 > > - test -z "$(sed -n -e "/^drwxrws---/d" -e "/^d/p" actual)" && > > Did you mean > > - # All directories must have 2770 > - test -z "$(sed -n -e "/^drwxrws---/d" -e "/^d/p" actual)" && > + # All directories must have either 2770 or 770 > + test -z "$(sed -n -e "/^drwxrw[sx]---/d" -e "/^d/p" actual)" && No, I meant what I said, but I was wrong. ;) I was thinking that bit only tested for one thing, but it was actually testing for two. Sorry. Can you fix it up when you apply, then? -Peff