From: Christian Couder <chriscool@tuxfamily.org>
Date: Tue, 31 Mar 2009 06:45:23 GMT
Subject: Re: [PATCH 07/10] rev-list: call new "filter_skip" function
Message-ID: <200903310845.23674.chriscool@tuxfamily.org>
In-Reply-To: <alpine.DEB.1.00.0903300951460.7534@intel-tinevez-2-302>

Hi,

Le lundi 30 mars 2009, Johannes Schindelin a écrit :
> Hi,
>
> On Mon, 30 Mar 2009, Christian Couder wrote:
> > Le jeudi 26 mars 2009, Junio C Hamano a écrit :
> > >
> > > I've learned to suspect without reading a qsort() callback that does
> > > not derefence its arguments.  Is this doing the right thing?
> >
> > I think so.
>
> I suspect something much worse: you are trying to build a list of sha1s
> of commits that need to be skipped, later to look up every commit via
> binary search.
>
> But it has been proven a lot of times that using a hash set is superior
> to that approach, and even better: we already have the framework in place
> in the form of struct decorate.

I had a look, and "struct decorate" can be used to store objects, but I want 
to store only sha1s.

Regards,
Christian.