From: Eric Wong <normalperson@yhbt.net>
Date: Sun, 29 Mar 2009 22:43:24 GMT
Subject: Re: [PATCH] git-svn: don't output git commits in quiet mode
Message-ID: <20090329224324.GB20675@dcvr.yhbt.net>
In-Reply-To: <49CFCD5A.1080801@simon.arlott.org.uk>

Simon Arlott <simon@fire.lp0.eu> wrote:
> Ideally only errors should be output in this mode so fetch
> can be run from cron and normally produce no output. Without
> this change it would output a single line on each git commit,
> e.g.
> r1909 = 32ef87860662526d4a62f903949ed21e0341079e (u2_10_12_branch)
> 
> Signed-off-by: Simon Arlott <simon@fire.lp0.eu>

Thanks Simon,

Acked-by: Eric Wong <normalperson@yhbt.net>

and pushed to git://git.bogomips.org/git-svn

> ---
>  git-svn.perl |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index 8be6be0..e100b69 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -2331,13 +2331,13 @@ sub do_git_commit {
>  
>  	$self->{last_rev} = $log_entry->{revision};
>  	$self->{last_commit} = $commit;
> -	print "r$log_entry->{revision}";
> +	print "r$log_entry->{revision}" unless $::_q;
>  	if (defined $log_entry->{svm_revision}) {
> -		 print " (\@$log_entry->{svm_revision})";
> +		 print " (\@$log_entry->{svm_revision})" unless $::_q;
>  		 $self->rev_map_set($log_entry->{svm_revision}, $commit,
>  		                   0, $self->svm_uuid);
>  	}
> -	print " = $commit ($self->{ref_id})\n";
> +	print " = $commit ($self->{ref_id})\n" unless $::_q;
>  	if (--$_gc_nr == 0) {
>  		$_gc_nr = $_gc_period;
>  		gc();
> -- 
> 1.6.2