From: Shawn O. Pearce Date: Wed, 25 Mar 2009 21:59:31 GMT Subject: Re: [PATCH JGIT 1/2] Calculate CRC32 on Pack Index v2 Message-ID: <20090325215931.GC23521@spearce.org> In-Reply-To: <49CA3218.9090202@gmail.com> Marek Zawirski wrote: > I just wonder if it is sensible to compute it always regardless of used > index version (outputVersion) - for index v1 we don't really need CRC32 > to be computed. I don't have a good idea how can it be avoided in truly > elegant way, as we cannot rely on the outputVersion checking in this > code - currently it may became changed after writing pack, but before > writing index. But maybe it's not so important issue, as AFAIR v2 is > already default version for index. If the index version is specifically set to 1, we may be forced to write a version 2 index if the pack file is huge, in which case we need the CRC32 data on each object. Since version 2 is the default, we probably hav to compute it no matter what. > Have you tested that code? It seems that CRC32 updates is missing in > write() method... or did I slept too short this night?:) Yea, its missing the updates in the write method. I'm writing up an alternate series of patches. -- Shawn.