From: Miklos Vajna <vmiklos@frugalware.org>
Date: Tue, 24 Mar 2009 01:23:34 GMT
Subject: Re: [PATCH 9/9] refs: use warning() instead of fprintf(stderr, "warning: ")
Message-ID: <20090324012334.GL27459@genesis.frugalware.org>
In-Reply-To: <40aa078e0903231817g41fd1bc1s296121d85923f7ea@mail.gmail.com>

On Tue, Mar 24, 2009 at 02:17:24AM +0100, Erik Faye-Lund <kusmabite@googlemail.com> wrote:
> > @@ -996,7 +996,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)
> >
> >        err = unlink(git_path("logs/%s", lock->ref_name));
> >        if (err && errno != ENOENT)
> > -               fprintf(stderr, "warning: unlink(%s) failed: %s",
> > +               warning("unlink(%s) failed: %s",
> 
> Doesn't this add a newline? The original string doesn't have a '\n' at
> the end of the format-field, but AFAIK warning() terminates with one.
> I'm not saying it's a problem, I'm just pointing it out.

Yes, it adds. As Jeff pointed out earlier in this thread, the lack of
newline was a bug:

http://article.gmane.org/gmane.comp.version-control.git/110783