From: Jeff King <peff@peff.net>
Date: Sun, 22 Mar 2009 22:33:09 GMT
Subject: Re: [RFC] git gui doesn't call post-checkout hook on checkout or clone
Message-ID: <20090322223309.GA22428@sigill.intra.peff.net>
In-Reply-To: <49C65DF1.8030608@web.de>

On Sun, Mar 22, 2009 at 04:49:05PM +0100, Jens Lehmann wrote:

> When checking out or cloning via git gui, the post-checkout
> hook is not called. This is a bit unexpected ...
> 
> The reason is that git gui uses git read-tree with the -u
> option and not git checkout and git clone. I changed git
> read-tree to call the post-checkout hook when called with
> -u and it seems to solve the problem. I would make a patch
> for that if you want.
> 
> But is this the right way to do this? Seems like we could
> surprise some users of git read-tree with this change in
> behaviour.

No, I think plumbing should not generally call hooks. The right solution
would be to have git-gui call the post-checkout hook.

-Peff