From: Johannes Sixt <j6t@kdbg.org>
Date: Sun, 22 Mar 2009 16:55:44 GMT
Subject: Re: [PATCH 13/16] t3700: Skip a test with backslashes in pathspec
Message-ID: <200903221755.44642.j6t@kdbg.org>
In-Reply-To: <7v3ad6cvub.fsf@gitster.siamese.dyndns.org>

On Sonntag, 22. März 2009, Junio C Hamano wrote:
> I do not think the justification for this change is explained well enough.
>
> The test prepares a file whose name consists of "ef, oh, bra, oh, you,
> ket, bee, ei and are" (no backslashes), and passes a filespec that quotes
> bra and ket with backslash so glob won't misinterpret as if we are asking
> to add "ef oh followed by either oh or you followed by bee ei are".  There
> is no path that has a backslash in it involved.
>
> If this does not work on Windows, there is something else going on.  Is it
> that the shell eats one level of backslash too much or something?

I added these two paragraphs:

The test verifies that glob special characters can be escaped with
backslashes.  In particular, the string fo\[ou\]bar is given to git.

On Windows, this does not work because backslashes are first of all
directory separators, and first thing git does with a pathspec from the
command line is to convert backslashes to forward slashes.

-- Hannes