From: Alex Riesen <raa.lkml@gmail.com>
Date: Thu, 19 Mar 2009 22:00:21 GMT
Subject: Re: [PATCH] Produce a nicer output in case of sha1_object_info failures in ls-tree -l
Message-ID: <20090319220020.GA8433@blimp.localdomain>
In-Reply-To: <7v4oxp89eb.fsf@gitster.siamese.dyndns.org>

Junio C Hamano, Thu, Mar 19, 2009 22:55:56 +0100:
> Alex Riesen <raa.lkml@gmail.com> writes:
> > @@ -91,6 +90,7 @@ static int show_tree(const unsigned char *sha1, const char *base, int baselen,
> >  	if (!(ls_options & LS_NAME_ONLY)) {
> >  		if (ls_options & LS_SHOW_SIZE) {
> >  			if (!strcmp(type, blob_type)) {
> > +				unsigned long size = 0;
> >  				sha1_object_info(sha1, &size);
> >  				printf("%06o %s %s %7lu\t", mode, type,
> >  				       abbrev ? find_unique_abbrev(sha1, abbrev)
> 
> Hmm, shouldn't you be checking the return value from sha1_object_info()
> and skipping the printf() altogether instead?

But then I cannot know the name of the failed tree entry.