From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Wed, 18 Mar 2009 06:34:59 GMT
Subject: Re: [JGIT PATCH 00/12] Improve test coverage in revwalk
Message-ID: <200903180734.59435.robin.rosenberg.lists@dewire.com>
In-Reply-To: <1237340451-31562-1-git-send-email-spearce@spearce.org>

onsdag 18 mars 2009 02:40:39 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> Most of these patches are to improve the test coverage within the
> revwalk package.
> 
> 
> The last commit points out what I feared, which is that a RevWalk
> with a PathFilter applied doesn't produce the same results that
> git-core would produce in the same situation.  We're either missing
> some functions necessary to implement it, or we flat out produce
> a wrong graph in some cases.
> 
> The tests are commented out because JUnit doesn't have a notion of
> "known broken".  But I did leave in TODO comments.  I'd like to
> apply the test, and then work later to improve it, but I'm open
> to suggestions.

If we'd switch to JUnit4/TestNG we could abuse the expected exception
annotation.

-- robin