From: Jeff King <peff@peff.net>
Date: Wed, 18 Mar 2009 05:52:22 GMT
Subject: Re: What's cooking in git.git (Mar 2009, #05; Tue, 17)
Message-ID: <20090318055222.GA17128@coredump.intra.peff.net>
In-Reply-To: <7vbprzo0si.fsf@gitster.siamese.dyndns.org>

On Tue, Mar 17, 2009 at 10:30:37PM -0700, Junio C Hamano wrote:

> * mv/parseopt-ls-files (Sat Mar 7 20:27:22 2009 -0500) 4 commits
>  + ls-files: fix broken --no-empty-directory
>  + t3000: use test_cmp instead of diff
>  + parse-opt: migrate builtin-ls-files.
>  + Turn the flags in struct dir_struct into a single variable
> 
> The tip one was a subject for further discussion, but nothing is queued
> yet.

I am inclined to leave it as-is. The other sane option would be
converting it to use NONEG, as Miklos suggested.

Doing it right would probably mean adding a "this option is the opposite
of what we would usually do" flag to parse-options which would display
the option as "no-<option>" in the usage, and would reverse clearing and
setting the bit (i.e., --empty-directory would clear the HIDE_DIRECTORY
bit and --no-empty-directory would set it). But I don't think it is
worth the work to add a negatable version of an option that has never
existed before and which nobody has requested to use.

-Peff