From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Tue, 17 Mar 2009 11:02:27 GMT
Subject: Re: [PATCH] config: test for --replace-all with one argument and fix documentation.
Message-ID: <20090317110227.GA2666@pengutronix.de>
In-Reply-To: <94a0d4530903170341g27f215d4t8c3ad25e7f362590@mail.gmail.com>

Hello,

On Tue, Mar 17, 2009 at 12:41:29PM +0200, Felipe Contreras wrote:
> On Tue, Mar 17, 2009 at 12:24 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> > Hi,
> >
> > On Tue, 17 Mar 2009, Carlos Rica wrote:
> >
> >> Option --replace-all only allows at least two arguments, so
> >> documentation was needing to be updated accordingly. A test showing
> >> that the command fails with only one parameter is also provided.
> >>
> >> Signed-off-by: Carlos Rica <jasampler@gmail.com>
> >
> > Looks obviously correct to me.  I am actually unsure if I can ACK this
> > patch, as most of builtin-config.c does not look all that familiar to me
> > anymore ;-)
> 
> Hehe... interesting, my first possibility of ack'ing :D (I guess)
> 
> Acked-by: Felipe Contreras <felipe.contreras@gmail.com>
It's not nice to ack in public that someone else doesn't know something
anymore. :-)

SCNR
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |