From: Jeff King <peff@peff.net>
Date: Tue, 17 Mar 2009 07:40:54 GMT
Subject: Re: Transparently encrypt repository contents with GPG
Message-ID: <20090317074054.GA18475@coredump.intra.peff.net>
In-Reply-To: <49BE77DD.5020407@drmicha.warpmail.net>

On Mon, Mar 16, 2009 at 05:01:33PM +0100, Michael J Gruber wrote:

> Now, a simple test shows that git diff obviously does this when diffing
> HEAD to worktree:
> 
> diff between HEAD and clean(worktree)
> 
> Which is the right thing. It just seems so that textconv is not even
> called "in the wrong place of the chain", but messes the diff up in this
> way:
> 
> diff between textconv(HEAD) and textconv(worktree)
> 
> (I expected clean(textconv(worktree)) first, which would be wrong, too).
> I.e., the clean filter is ignored completely in the presence of textconv.

Yeah, I think this should probably be textconv(clean(worktree)) to match
the regular HEAD/worktree diff (if it isn't already). Can you put
together a test that shows the breakage?

-Peff