From: Shawn O. Pearce <spearce@spearce.org>
Date: Mon, 16 Mar 2009 21:28:31 GMT
Subject: Re: [EGIT PATCH 02/10] Rename the objectsUrl in the nested HttpObjectDB to
Message-ID: <20090316212831.GU22920@spearce.org>
In-Reply-To: <200903162225.00347.robin.rosenberg.lists@dewire.com>

Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> måndag 16 mars 2009 21:25:13 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> > Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > > It is used for looking at alternate objects, so name it such
> > 
> > No SOB?
> > 
> > But I disagree with this name change.  Its pointing at the
> > objects directory of a repository.  It may also be used to
> > point at an alternate when opening an alternate, in which
> > case it points at the alternate's objects directory.
> > 
> > IMHO, objectsUrl is the right name for this.
> 
> Ok, I missed the real reason in the comment. It is name hiding. objectsUrl
> is the name of another variable in the outer scope.

OK.

I still disagree with the name change.  Can we hide the outer name by
making it private?  Or come up with a better name for the inner one?

-- 
Shawn.