From: Karl Hasselström <kha@treskal.com>
Date: Fri, 13 Mar 2009 02:27:51 GMT
Subject: Re: [StGit PATCH 4/5] Convert "sink" to the new infrastructure
Message-ID: <20090313022751.GD15393@diana.vm.bytemark.co.uk>
In-Reply-To: <20090312120913.2992.21403.stgit@pc1117.cambridge.arm.com>

Nicely done.

  Acked-by: Karl Hasselström <kha@treskal.com>

On 2009-03-12 12:09:13 +0000, Catalin Marinas wrote:

> +    applied = applied[:insert_idx] + patches + applied[insert_idx:]
> +
> +    unapplied = [p for p in stack.patchorder.unapplied if p not in patches]
> +    hidden = list(stack.patchorder.hidden)
> +
> +    iw = stack.repository.default_iw
> +    clean_iw = not options.keep and iw or None
> +    trans = transaction.StackTransaction(stack, 'sink',
> +                                         check_clean_iw = clean_iw)
> +
> +    try:
> +        trans.reorder_patches(applied, unapplied, hidden, iw)

Hmm. We should maybe have a default value for hidden: the current list
of patches. Not changing the hidden patches is a common operation.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle