From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Thu, 12 Mar 2009 07:45:24 GMT
Subject: Re: [PATCH 2/2] [TopGit] Portability: Don't use alternation ("|") in sed regular expressions
Message-ID: <20090312074524.GA14844@pengutronix.de>
In-Reply-To: <7viqmfjklm.fsf@gitster.siamese.dyndns.org>

Hello Brian, hello Junio,

On Wed, Mar 11, 2009 at 11:55:49PM -0700, Junio C Hamano wrote:
> Brian Campbell <brian.p.campbell@dartmouth.edu> writes:
> 
> > +current_branch()
> > +{
> > +	echo "$(git symbolic-ref HEAD | sed -e 's#^refs/heads/##' -e 's#^refs/top-bases/##')"
> > +}
> 
> Two micronits.
> 
>  - what happens when you are on a detached HEAD?
The original code had this problem, too, so I would not take this as a
stopper for the patch.  There are some other locations that suffer from
the same problem.  That's already on my todo list.  So I don't care much
here.
 
>  - You will be utterly confused by a local branch whose name is
>    "refs/top-bases/foo"
You mean a branch that has the full name refs/heads/refs/top-bases/foo?
Well OK, valid concern.

> To fix these, you might want to do something like:
> 
> 	if head_=$(git symbolic-ref HEAD)
>         then
>                 case "$head_" in
>                 refs/heads/*)
>                         echo "${head_#refs/heads/}"
>                         ;;
>                 refs/top-bases/*)
>                         echo "${head_#refs/top-bases/}"
>                         ;;
>                 *)
>                         echo "$head_"
>                         ;;
>                 esac
> 	else
>         	whatever you want to do on a detached HEAD
> 	fi
Thanks Junio and Brian.

Brian, do you update the series?

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |