From: Shawn O. Pearce Date: Fri, 06 Mar 2009 16:32:33 GMT Subject: Re: [PATCH 2/3] bash completion: refactor --strategy completion Message-ID: <20090306163233.GL16213@spearce.org> In-Reply-To: <1236357044-55479-1-git-send-email-jaysoffian@gmail.com> Jay Soffian wrote: > The code to complete --strategy was duplicated between _git_rebase and > _git_merge, and is about to gain a third caller (_git_pull). This patch > factors it into its own function. > > Signed-off-by: Jay Soffian > --- > How about like this intead? This way 3/3 doesn't need to be adjusted. The > interdiff is: Yup, that works too! Acked-by: Shawn O. Pearce > contrib/completion/git-completion.bash | 38 ++++++++++++++++--------------- > 1 files changed, 20 insertions(+), 18 deletions(-) -- Shawn.