From: Shawn O. Pearce Date: Fri, 06 Mar 2009 16:16:57 GMT Subject: Re: [PATCH 2/3] bash completion: refactor --strategy completion Message-ID: <20090306161657.GJ16213@spearce.org> In-Reply-To: <76718490903060812q2e7b2eefg5f25c9845f678959@mail.gmail.com> Jay Soffian wrote: > On Fri, Mar 6, 2009 at 11:04 AM, Shawn O. Pearce wrote: > > Jay Soffian wrote: > >> The code to complete --strategy was duplicated between _git_rebase and > >> _git_merge, and is about to gain a third caller (_git_pull). This patch > >> factors it into its own function. > >> > >> Signed-off-by: Jay Soffian > > > > Looks OK to me, but I had to squash this in to get it to work. > > Without this the patch breaks git merge completion entirely: > > Weird, I had it completely backwards but it seemed to work. Probably > because I was sourcing the new completion into my running shell; I'll > make sure to startup a new shell next time. > > With the squash (assuming Junio doesn't mind), is it acked-by you or > should I resend? Sorry, yes, with the squash it is Ack'd. -- Shawn.