From: Shawn O. Pearce Date: Wed, 04 Mar 2009 18:57:42 GMT Subject: Re: [RFC/PATCH 1/2] improve missing repository error message Message-ID: <20090304185742.GI14365@spearce.org> In-Reply-To: <20090304083229.GA31798@coredump.intra.peff.net> Jeff King wrote: > Certain remote commands, when asked to do something in a > particular directory that was not actually a git repository, > would say "unable to chdir or not a git archive". The > "chdir" bit is an unnecessary detail, and the term "git > archive" is much less common these days than "git repository". > > So let's switch them all to: > > fatal: '%s' does not appear to be a git repository > > Signed-off-by: Jeff King Acked-by: Shawn O. Pearce > On Tue, Mar 03, 2009 at 10:41:06AM -0800, Shawn O. Pearce wrote: > > > IMHO, maybe we also should change the error message that receive-pack > > produces when the path its given isn't a Git repository. Its really > > not very human friendly to say "unable to chdir or not a git archive". > > Hell, we don't even call them archives, we call them repositories. I really mean to write this patch myself, I haven't done much for git lately. But I got sidetracked yesterday and forgot. Thank you for doing it for me. > Perhaps this should match the local "Not a git repository: %s". I prefer > this text, but maybe there is value in consistency. FWIW I also prefer the text you used in the patch... -- Shawn.