From: Jeff King <peff@peff.net>
Date: Tue, 24 Feb 2009 07:07:22 GMT
Subject: Re: [PATCH 2/2] --date=relative falls back to "short" format for commits older than a year
Message-ID: <20090224070722.GA16566@coredump.intra.peff.net>
In-Reply-To: <7v63j0mib5.fsf@gitster.siamese.dyndns.org>

On Mon, Feb 23, 2009 at 10:59:26PM -0800, Junio C Hamano wrote:

> That was what I thought.  There may be some very convincing reasoning I am
> not seeing in the proposals to make it ultra-short like "Y yr M mo" or
> "Y.x years" (i.e. "we _have_ to keep it under N characters"threshold), but
> I doubt there is a particular place "Y years, M months" would make the
> output too long to be acceptable.

Yeah, anything like blame that deals with arbitrary date formats has to
know how to handle at least

  strlen("Sun Feb 22 15:08:25 2009 -0500") = 30

anyway.  Even the default blame format is:

  strlen("2009-02-24 02:03:25 -0500") = 25

So "Y years, M months ago" is at least that short for the next ten
thousand years. I can live with setting the cutoff to just "years"
somewhere lower than 10,000. :)

-Peff