From: Jeff King <peff@peff.net>
Date: Mon, 23 Feb 2009 06:45:10 GMT
Subject: Re: [PATCH 09/13] refactor duplicated ref_newer() to remote.c
Message-ID: <20090223064510.GA24517@coredump.intra.peff.net>
In-Reply-To: <7f19e98ccc330d4094ffbb55ea06c35b91da9e55.1235368324.git.jaysoffian@gmail.com>

On Mon, Feb 23, 2009 at 01:28:57AM -0500, Jay Soffian wrote:

> ref_newer() appears to have been copied from builtin-send-pack.c to
> http-push.c via cut and paste. This patch moves the function and its
> helper unmark_and_free() to remote.c.
> 
> Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
> ---
> Hmm, I just noticed that the version in builtin-send-pack.c uses 1
> whereas http-push.c uses TMP_MARK as the mark argument. I used the
> version from builtin-send-pack.c. I don't know if this is signfificant.

I think the TMP_MARK one is probably better. At the very least, the
send-pack one should be using SEEN instead of a bare '1'. But given that
it is not part of the usual revision machinery, it seems like that was
what TMP_MARK was designed for.

-Peff