From: Jeff King <peff@peff.net>
Date: Fri, 20 Feb 2009 03:02:45 GMT
Subject: Re: [PATCH 1/8] builtin-apply: use warning() instead of fprintf(stderr, "warning: ")
Message-ID: <20090220030245.GC22419@coredump.intra.peff.net>
In-Reply-To: <4f61642d10063adbff86094e91b1b6e90efabe8e.1235047192.git.vmiklos@frugalware.org>

On Thu, Feb 19, 2009 at 01:53:10PM +0100, Miklos Vajna wrote:

> @@ -2932,8 +2932,7 @@ static int write_out_one_reject(struct patch *patch)
>  	cnt = strlen(patch->new_name);
>  	if (ARRAY_SIZE(namebuf) <= cnt + 5) {
>  		cnt = ARRAY_SIZE(namebuf) - 5;
> -		fprintf(stderr,
> -			"warning: truncating .rej filename to %.*s.rej",
> +		warning("truncating .rej filename to %.*s.rej",
>  			cnt - 1, patch->new_name);
>  	}

Hmm. This hunk is actually changing behavior, as the original didn't
have a newline. It looks like a bug in the original, though.

Other than that, these all look pretty straightforward. Probably the
shell scripts should be switched to match, too. But it would be nice to
hear from Junio first that this cleanup is even desired (so you don't
waste time).

-Peff