From: Shawn O. Pearce <spearce@spearce.org>
Date: Wed, 18 Feb 2009 15:46:20 GMT
Subject: Re: [JGIT PATCH v2] Fixed QuotedStringGitPathStyleTest.testDequote_OctalAll test that generated incorrect UTF-8 escape sequences
Message-ID: <20090218154620.GA22848@spearce.org>
In-Reply-To: <85647ef50902161050i43b478d4kb7faaa211dee727d@mail.gmail.com>

Constantine Plotnikov <constantine.plotnikov@gmail.com> wrote:
> The test was failing on the system that use a encoding different
> from ISO-8859-1. The reason was that invalid UTF-8 bytes were
> generated for codepoints greater than U+7F, and in this case
> the method RawParseUtils.decodeNoFallback falls backs to the
> default system encoding.
> 
> Signed-off-by: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>

Thanks.

> The bug was causing failure for the maven build on the windows
> environment that uses Cp1251 as a system encoding. However the test
> worked from Eclipse until I have specified jvm option
> -Dfile.ecoding=Cp1251, in the test case started to fail in Eclipse as
> well.

-- 
Shawn.