From: Jeff King Date: Wed, 18 Feb 2009 10:16:15 GMT Subject: Re: [PATCH v2 4/5] t3301: use test_must_fail instead of ! Message-ID: <20090218101615.GA23035@coredump.intra.peff.net> In-Reply-To: On Wed, Feb 18, 2009 at 11:14:10AM +0100, Johannes Schindelin wrote: > > I can now get as far as t3404, which seems to have problems due to > > rebase-interactive using parentheses, "-a", and "-o" with "test". > > The parentheses will be fixed soon, but "-a" and "-o" really are > necessary. Really? Are they not easily replaced with -test cond1 -a cond2 -o cond3 +test cond1 && test cond2 || test cond3 ? The trickier part is the grouping, but that is what the parentheses are doing. -Peff