From: Lars Noschinski Date: Tue, 17 Feb 2009 08:17:28 GMT Subject: Re: [PATCH] filter-branch -d: Export GIT_DIR earlier Message-ID: <20090217081728.GA3893@lars.home.noschinski.de> In-Reply-To: * Johannes Schindelin [09-02-16 18:52]: >Hi, > >On Mon, 16 Feb 2009, Lars Noschinski wrote: > >> * Johannes Schindelin [09-02-16 15:42]: >> > > This fix is not yet ready for commit, as it lacks a test case. >> > > >> > > Writing a test case for this bug, I wonder about the preferred way to use >> > > a >> > > directory outside any git repository in a test: Using some directory below >> > > git/t/ will not work, as (in most cases) git is a git repository. [...] >Next try: is it not true that we can check that "$tempdir/backup-refs" >is correct, i.e. identical to what 'for-each-ref' outputs for the desired >directory? True. >So we could make a subdirectory, set up a dummy branch with one commit, >call filter-branch with a tmpdir that is in _another_ subdirectory, with a >filter that just returns false, so that the tmpdir is not deleted, and >verify the contents of $tmpdir/backup-refs, no? AFAICS $tmpdir is always deleted, filter-branch sets a trap to ensure this. But using a filter to copy backup-refs elsewhere works. Patch follows. - Lars.