From: Jeff King <peff@peff.net>
Date: Thu, 12 Feb 2009 00:18:36 GMT
Subject: Re: [PATCH 1/3] builtin-remote: move duplicated cleanup code its own function
Message-ID: <20090212001836.GB30231@coredump.intra.peff.net>
In-Reply-To: <1234332083-45147-2-git-send-email-jaysoffian@gmail.com>

On Wed, Feb 11, 2009 at 01:01:21AM -0500, Jay Soffian wrote:

> +static void free_remote_ref_states(struct ref_states *states)
> +{
> +	/* NEEDSWORK: free remote */
> +	string_list_clear(&states->new, 0);
> +	string_list_clear(&states->stale, 0);
> +	string_list_clear(&states->tracked, 0);
> +}

Hmm. I don't know anything about this code, so maybe it is not trivial.
But anytime you are touching an area that NEEDSWORK, I think it is worth
looking at whether you can fix that problem (since you have already
spent a few brain cycles understanding what is going on in general).

-Peff