From: Jeff King <peff@peff.net>
Date: Tue, 10 Feb 2009 15:30:48 GMT
Subject: Re: A little mystery - crash caused by empty commit message.
Message-ID: <20090210153048.GA17660@coredump.intra.peff.net>
In-Reply-To: <1a6be5fa0902100458w246f2bfeu5c0c303d18d17a3b@mail.gmail.com>

On Tue, Feb 10, 2009 at 01:58:43PM +0100, Tor Arvid Lund wrote:

> So - after the "+0100" on the committer line, hd tells me (as
> expected) that I have 0a 0a before "[HIA]". On the "faulty" commit I,
> for some reason, have 0a 00 instead. I do not understand why, but I
> guess strchr will return NULL when "\0[HIA]....." is passed to it, and
> segfault on the next iteration.
> 
> So - I am no closer to understanding what got me to this state, but
> your reply was helpful anyway, thanks :-)

Well, it certainly seems like a bug in one of the history-rewriting
programs. Can you try rebasing, cherry-picking, etc on the original
version of the commit to see if you can reproduce the breakage?

-Peff