From: Christian Couder <chriscool@tuxfamily.org>
Date: Sat, 07 Feb 2009 18:09:14 GMT
Subject: Re: Article about "git bisect run" on LWN
Message-ID: <200902071909.14752.chriscool@tuxfamily.org>
In-Reply-To: <ee77f5c20902070455h360d8476re76294735673b4ca@mail.gmail.com>

Le samedi 7 février 2009, David Symonds a écrit :
> On Sat, Feb 7, 2009 at 3:41 PM, Christian Couder
>
> <chriscool@tuxfamily.org> wrote:
> > It might be useful to have a list of always good commits too, and use
> > it like this:
> >
> > $ git bisect start <bad> <good> $(cat always_good.txt)
> > $ git bisect skip $(cat always_skipped.txt)
> > $ git bisect run ./my_test_script.sh
>
> Your test script could just do this at its start instead:
>
>   if cat always_good.txt | grep $(rev-parse HEAD); then
>     exit 0

This won't work, because when you give one good rev, you say that all the 
ancestors of this rev are good (not just that the rev you give is good).

>   elif cat always_skipped.txt | grep $(rev-parse HEAD); then
>     exit 125
>   fi

If you have a range like v1..v2 in "always_skipped.txt" this won't work.
And anyway it may be less efficient because it may perform many useless 
checkouts.

Regards,
Christian.