From: Robin Rosenberg Date: Thu, 05 Feb 2009 20:02:00 GMT Subject: Re: [EGIT PATCH 06/11] Implement basic customizable label decorations with preferences Message-ID: <200902052102.00409.robin.rosenberg@dewire.com> In-Reply-To: <1233795618-20249-7-git-send-email-torarnv@gmail.com> torsdag 05 februari 2009 02:00:13 skrev Tor Arne Vestbø: > Currently the only binding available is the resource name, but > this commit enables a framework for adding more bindings. The size of the components of the page is wrong forcing unnecessary scrollbars. The terms use should probably have a cleared explanation/definition and the same terms used for the flags/icons. The explanation could probably be done using longer tooltips. I miss the red attention-gathering red conflict icon we had. I also have a hard time distinguishing the staged/added/removed icons without reading glasses. The decorations are only 1.3 mm on my screen (150 dpi), so I think the icons should have different colors and different shapes instead of a few different pixels withing a square box. I'd also like to see the conflict state for files inherited by parent folder and projects. The checkboxes in the general tab have no effect on the preview. -- robin