From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Thu, 05 Feb 2009 18:32:24 GMT
Subject: Re: [EGIT PATCH 00/11] Support customizable label decorations
Message-ID: <200902051932.24600.robin.rosenberg.lists@dewire.com>
In-Reply-To: <20090205160625.GI26880@spearce.org>

torsdag 05 februari 2009 17:06:25 skrev Shawn O. Pearce:
> > Known issues are:
> > 
> >   - If a project has a repository more than one level above the
> >     project directory decorations will fail.
> 
> I'd like to see this fixed in the near-ish future, but I don't
> think its blocking to merging your patches.

I'm not sure this is Tore's bug. We've had problems with nested
repos before.

> >   - When a Java resource is dirty, each parent package in the
> >     package hierarcy will appear dirty, even when the layout is
> >     set to 'flat'.
> 
> Bah.  I've seen the Java compiler error marks also report like this.
> I don't think its our issue.  But maybe I'm wrong.

It's our choice here. Generally, I think we should shift behavior here
depending on layout. Java packages are not hierarchical in nature.

Currently it may look like this with flat package layout:

	>org.spearce.jgit.treewalk
		CanonicalTreeParserTest.java
		EmptyTreeIteratorTest.java
		FileTreeIteratorTest.java
		NameConflictTreeWalkTest.java
		PostOrderTreeWalkTest.java
		TreeWalkBasicDiffTest.java

	>org.spearce.jgit.treewalk.filter
		AlwaysCloneTreeFilter.java
		>NotTreeFilterTest.java
		TreeFilterTest.java


Which is odd when looking at org.spearce.jgit.treewalk, because
no files in that package have been changed. A tricky question is
how to decorate empty packages. like org, org.spearce. Probably
as unchanged.

-- robin