From: Eric Wong Date: Thu, 05 Feb 2009 07:42:15 GMT Subject: Re: [PATCH] git-svn: allow disabling expensive broken symlink checks Message-ID: <20090205074215.GA24887@dcvr.yhbt.net> In-Reply-To: <20090203191021.GB2077@dcvr.yhbt.net> Eric Wong wrote: > Junio C Hamano wrote: > > Eric Wong writes: > > > > >> How common is this breakage in people's subversion repositories that > > >> dbc6c74d (git-svn: handle empty files marked as symlinks in SVN, > > >> 2009-01-11) works around? > > > > > > It's not common at all. Some broken Windows clients were able to > > > create it. > > > > > >> What's the way to recover from a broken import, when the subversion > > >> repository does have such a breakage, and the user used git-svn that > > >> predates dbc6c74? Is it very involved, and it is much better to have the > > >> safety by default than to force everybody else who interacts with > > >> non-broken subversion repository suffer from this performance penalty? > > > > > > Previously, git-svn would just stop importing and refuse to continue. > > > So allowing the user to enable it would be a problem; too. I don't > > > recall the error being easy to distinguish from other errors. Actually I was wrong on git-svn refusing to continue. git-svn will create a regular 100644 file with "link path/to/dest" as its contents. git-svn only croaks on checksum differences with the blob itself; it does not have an easy way to verify the mode change => 120000 if it happened previously. > > >> Because the fix (that is broken from the performance angle) is relatively > > >> recent, I am wondering if it makes more sense to turn it off by default, > > >> and allow people with such a broken history to optionally turn it on. > > > > > > I'm considering disabling it by default, too. I'm considering keeping it on by default given the above (re)discovery... -- Eric Wong