From: Jeff King Date: Wed, 04 Feb 2009 14:53:17 GMT Subject: Re: [PATCH] config: Add new option to open an editor. Message-ID: <20090204145317.GA5712@sigill.intra.peff.net> In-Reply-To: <1233700826-11763-1-git-send-email-felipe.contreras@gmail.com> On Wed, Feb 04, 2009 at 12:40:26AM +0200, Felipe Contreras wrote: > + } else if (!strcmp(argv[1], "--edit") || !strcmp(argv[1], "-e")) { > + char *config_filename; > + if (config_exclusive_filename) > + config_filename = xstrdup(config_exclusive_filename); > + else > + config_filename = git_pathdup("config"); > + launch_editor(config_filename, NULL, NULL); > + free(config_filename); > + return 0; > } else With this patch, won't I get different behavior from: git config -e --global versus git config --global -e ? Other than that, I like the concept of this patch. -Peff