From: Jeremy O'Brien Date: Tue, 03 Feb 2009 19:42:58 GMT Subject: Re: git grep -I bug Message-ID: <20090203194258.GA1354@Ambelina.snd-wireless.uc.edu> In-Reply-To: <7v1vugf8gc.fsf@gitster.siamese.dyndns.org> On Mon, Feb 02, 2009 at 08:30:43PM -0800, Junio C Hamano wrote: > Jeremy O'Brien writes: > > > On Mon, Feb 02, 2009 at 09:54:31AM -0800, Junio C Hamano wrote: > >> Jeremy O'Brien writes: > >> > >> > I am running git version 1.6.1.2.309.g2ea3. > >> > > >> > When I use > >> > > >> > git grep -I "string_to_match" > >> > > >> > to ignore binary files in my grep, binary files are returned anyway. > >> > >> One sanity check. What does 'git grep --cached -I "string_to_match"' do > >> in that case? > >> > > > > It works as expected. It is interesting that while my Linux install was > > affected by this bug, my Mac OS X install did not seem to be affected by > > it, while running the same version of git. > > Perhaps your Mac OSX binary was built without external grep support. > > Did the patch fix the issue, by the way? I'm assuming that was the problem. And yes, the patch fixed it just fine, thank you.