From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Wed, 28 Jan 2009 20:10:48 GMT
Subject: Re: [JGIT PATCH] Add getTaggerIdent, getShortMessage, getFullMessage to RevTag
Message-ID: <200901282110.48899.robin.rosenberg.lists@dewire.com>
In-Reply-To: <1233117316-3291-1-git-send-email-spearce@spearce.org>

onsdag 28 januari 2009 05:35:16 skrev Shawn O. Pearce:
> These methods make the RevTag API more like the RevCommit API, such
> that it is more consistent for applications to access the "fields"
> of a tag object in the same way that they access the fields of any
> commit object.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
> 
>  Actually, this has also gone through Gerrit2.  If you want to see
>  what the same patch looks like (just for fun):

The reviewer is biased :) Where are the unit tests?

I'm kind of surprised you did not optimized skipping past the object header,
like the parents are skipped when parsing commits.

-- robin