From: Jeff King Date: Wed, 28 Jan 2009 07:43:34 GMT Subject: Re: [PATCHv2 3/4] run-command: help callers distinguish errors Message-ID: <20090128074334.GB31951@coredump.intra.peff.net> In-Reply-To: <20090128073639.GC31884@coredump.intra.peff.net> On Wed, Jan 28, 2009 at 02:36:39AM -0500, Jeff King wrote: > +#define IS_RUN_COMMAND_ERR(x) (x >= ERR_RUN_COMMAND_FORK) This should be "<= -ERR_RUN_COMMAND_FORK", since we expect the negated status. Maybe it is time I wrote a test for a failed external. -Peff