From: Jeff King <peff@peff.net>
Date: Mon, 26 Jan 2009 00:14:52 GMT
Subject: Re: [PATCH v3 2/3] valgrind: ignore ldso and more libz errors
Message-ID: <20090126001451.GA20256@coredump.intra.peff.net>
In-Reply-To: <alpine.DEB.1.00.0901260101030.14855@racer>

On Mon, Jan 26, 2009 at 01:02:24AM +0100, Johannes Schindelin wrote:

> > Your 0/3 cover letter lists this me as the author of this patch, but 
> > there is no "From:" line at the top of this email. I don't particularly 
> > care one way or the other for this patch, but I wanted to point it out 
> > as a potential issue with your patch-sending workflow.
> 
> Yep, sorry.  I would not touch send-email with lead-protected gloves, so 
> what I do is to edit all patches I send.  And in this case, I missed the 
> fact that there was another "From:".  I am sorry.

Heh. I certainly can't blame you for that; I don't use send-email
myself.

It might be convenient for format-patch to have a mode where it uses the
committer as the rfc822 "From:" and then adds a "From:" for the author
in the body if it is not the same as the committer.

It certainly shouldn't be the default, since that would confuse things
like rebase. But it makes sense if you are just going to throw away the
From header anyway when you import into your MUA.

-Peff