From: Jeff King Date: Sun, 25 Jan 2009 23:42:04 GMT Subject: Re: [PATCH v3 1/3] Add valgrind support in test scripts Message-ID: <20090125234204.GA19202@coredump.intra.peff.net> In-Reply-To: On Mon, Jan 26, 2009 at 12:35:31AM +0100, Johannes Schindelin wrote: > > I actually kind of liked the original atomic version over the one with > > locking. But I find this one acceptable. > > The locking is only in there because of you... I know it came out of our discussion, but I thought it was going a bit far. That is, what should ideally be a little chunk of code to make some links keeps getting more and more complex. And as your locking patch came after my "OK, I guess this is fine" comments, I thought you realized I was accepting it as-is. So sorry to make you to go to extra work (and please don't go to extra work ripping it out on my account -- I just wanted to make clear that I decided your analysis was sane, and that I am OK with any of the iterations you posted). -Peff