From: Jeff King <peff@peff.net>
Date: Sat, 24 Jan 2009 19:17:01 GMT
Subject: Re: [PATCH 1/2] handle color.ui at a central place
Message-ID: <20090124191700.GA17935@coredump.intra.peff.net>
In-Reply-To: <7vk58ko8k7.fsf@gitster.siamese.dyndns.org>

On Sat, Jan 24, 2009 at 10:36:24AM -0800, Junio C Hamano wrote:

> Why should format-patch need to even worry about protecting itself from
> "color.ui" to begin with?

Agreed. In the "should I use color" function I proposed, there should be
a big fat "are_we_a_porcelain_that_will_allow_any_color_at_all" flag
at the top, which will make it totally clear how to make sure color is
off.

> You did not find the breakage in format-patch either to begin with; so
> your not finding does not give us much confidence that there is no other
> breakage, does it?
> 
> Grumble...

Sadly, this is an area that is not covered very well in the tests
(partially, I think, because it is "just" output which we tend to
neglect, and partially because the isatty() stuff is hard to test with
our harness). So I don't think it's _entirely_ Markus' fault.

-Peff