From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Sat, 24 Jan 2009 14:23:24 GMT
Subject: Re: [PATCH 1/2] handle color.ui at a central place
Message-ID: <200901241523.24845.markus.heidelberg@web.de>
In-Reply-To: <alpine.DEB.1.00.0901241513460.13232@racer>

Johannes Schindelin, 24.01.2009:
> Hi,
> 
> On Sat, 24 Jan 2009, Markus Heidelberg wrote:
> 
> > format-patch is perhaps the only place where the commit has broken 
> > things, because I didn't find other places, where color config options 
> > were set
(and evaluated)
> > , but not the corresponding variables. So it seems as if only 
> > format-patch needed code like this to turn off the colors.
> 
> So you want to add a test case when you resubmit your patch...

I'm not sure, whether it should be resubmitted at all. As Jeff pointed
out, there should be a better way to clean up the color (and color.ui)
handling.

Markus