From: Jeff King <peff@peff.net>
Date: Tue, 20 Jan 2009 04:06:17 GMT
Subject: Re: [PATCH 2/2] expand --pretty=format color options
Message-ID: <20090120040617.GB30714@sigill.intra.peff.net>
In-Reply-To: <7vljt6q4cf.fsf@gitster.siamese.dyndns.org>

On Mon, Jan 19, 2009 at 03:10:56PM -0800, Junio C Hamano wrote:

> > Hrm. OK, it doesn't actually work always. It does for git-log, but not
> > for rev-list, which leaves diff_use_color_default as -1. I don't know if
> > there are any other ways you can get to this code path without having
> > set diff_use_color_default.
> 
> Yuck, no matter what you do please don't contaminate plumbing with the UI
> color options.

Of course. But the problem is that rev-list is _already_ contaminated by
--pretty=format:%Cred. Or do you mean, you really want rev-list to
unconditionally output color in such a case?

-Peff