From: Shawn O. Pearce Date: Mon, 19 Jan 2009 17:31:53 GMT Subject: Re: [PATCH next resend] bash completion: refactor diff options Message-ID: <20090119173153.GB14053@spearce.org> In-Reply-To: <7vtz7xytdo.fsf@gitster.siamese.dyndns.org> Junio C Hamano wrote: > Thomas Rast writes: > > > +__git_diff_common_options="--stat --numstat --shortstat --summary > > --patch-with-stat --name-only --name-status --color > > --no-color --color-words --no-renames --check > > --full-index --binary --abbrev --diff-filter= > > - --find-copies-harder --pickaxe-all --pickaxe-regex > > + --find-copies-harder > > The changes around pickaxe made me "Huh?". For log pickaxe makes very > good sense but for a single diff it doesn't, yet the original seems to > have had them only on "git diff" and not on "git log", which feels wrong. > > Other than that, I think the patch tries to achieve a great thing in the > longer term---we do not have to worry about common parts going out of sync > between diff and log family of commands. I agree completely. The pickaxe stuff in current completion is just plain wrong. I'd like to see it fixed with this cleanup. Maybe do it in two parts; fix the pickaxe options to be on log and not diff, and then do the cleanup for the common options. -- Shawn.