From: Johannes Sixt <j6t@kdbg.org>
Date: Sun, 18 Jan 2009 19:16:54 GMT
Subject: Re: [PATCH 3/7 v2] git_extract_argv0_path(): Move check for valid argv0 from caller to callee
Message-ID: <200901182016.56395.j6t@kdbg.org>
In-Reply-To: <1232280015-8144-4-git-send-email-prohaska@zib.de>

On Sonntag, 18. Januar 2009, Steffen Prohaska wrote:
> This simplifies the calling code.

But it could really be squashed into the previous patch, after fixing...

> @@ -23,6 +23,9 @@ const char *system_path(const char *path)
>
>  const char *git_extract_argv0_path(const char *argv0)
>  {
> +	if (!argv0 || !*argv0)
> +		return 0;
> +
>  	const char *slash = argv0 + strlen(argv0);

... this declaration after statement.

-- Hannes