From: Jeff King <peff@peff.net>
Date: Sun, 18 Jan 2009 17:36:46 GMT
Subject: Re: [PATCH 1/2] color: make it easier for non-config to parse color specs
Message-ID: <20090118173645.GA22680@coredump.intra.peff.net>
In-Reply-To: <20090118172802.GA17434@coredump.intra.peff.net>

On Sun, Jan 18, 2009 at 12:28:02PM -0500, Jeff King wrote:

> I don't know if this is really even worth it. The timing difference is
> pretty minimal:

BTW, if we really care about every inch of performance in
--pretty=format:, it would probably make sense to pre-parse the string
into a mini-bytecode. So any complex parsing or lookup that is not
dependent on the commit itself can be done once, instead of per-commit.

I don't think it would make a huge performance difference now, but there
has been talk of more complex substitution syntax (and this %C() is an
example), which would probably benefit.

-Peff