From: Karl Hasselström <kha@treskal.com>
Date: Thu, 15 Jan 2009 08:26:14 GMT
Subject: Re: [StGit PATCH] Add --file option to pick
Message-ID: <20090115082614.GA24890@diana.vm.bytemark.co.uk>
In-Reply-To: <20090114225930.11098.2144.stgit@localhost.localdomain>

On 2009-01-14 22:59:30 +0000, Catalin Marinas wrote:

> +    opt('-f', '--files', action = 'append',
> +        short = 'Only fold the given files'),

The long form should probably be "--file", since you only list one
file for every flag (and since you call it "--file" in the last hunk).
And the help text could be something like

  Only fold the given file (for multiple files, use -f more than once)

> +                raise CmdException, 'Patch folding failed'

This is not important, but I believe the recommended syntax for
raising exceptions nowadays is

  CmdException('Patch folding failed')

since that's what'll continue to work in Python 3, or something like
that. (I see you already use it in the multi-line case in the other
patch, where this syntax is clearly the better choice.)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle