From: Clemens Buchacher Date: Thu, 15 Jan 2009 08:20:18 GMT Subject: Re: [PATCH 3/3] implement pattern matching in ce_path_match Message-ID: <20090115082017.GA7801@localhost> In-Reply-To: <7vvdshzfpk.fsf@gitster.siamese.dyndns.org> On Wed, Jan 14, 2009 at 02:27:03PM -0800, Junio C Hamano wrote: > In places we read paths from the index or from the work tree and add them > as pathspec elements---you would want to mark them as non-globbing, too. > Which probably means that "is it Ok to glob this" setting has to be per > pathspec array elements. Right. This certainly complicates things. Also note that this invalidates 1/3, because even if '?' matched exactly, it can still match '*', and vice versa. Depending on ordering one of these two cases would pose a problem.