From: Jeff King <peff@peff.net>
Date: Wed, 14 Jan 2009 16:53:21 GMT
Subject: Re: [PATCH 3/3] implement pattern matching in ce_path_match
Message-ID: <20090114165321.GB15758@coredump.intra.peff.net>
In-Reply-To: <2009-01-14-17-18-40+trackit+sam@rfc1149.net>

On Wed, Jan 14, 2009 at 05:18:39PM +0100, Samuel Tardieu wrote:

> My taste would favor:
> 
>   static int has_special(const char *p)
>   {
>     for (; *p; p++)
>       if (isspecial(*p))
>         return 1;
>     return 0;
>   }

That was my first thought upon reading the other two, as well. And I
agree with all of the reasoning you gave.

-Peff